fix: remove unnecessary clone in generate_statics#547
Open
DeVikingMark wants to merge 2 commits intonexus-xyz:mainfrom
Open
fix: remove unnecessary clone in generate_statics#547DeVikingMark wants to merge 2 commits intonexus-xyz:mainfrom
DeVikingMark wants to merge 2 commits intonexus-xyz:mainfrom
Conversation
Contributor
|
Going to leave this pending since the precompile work is still in an intermediary state, and so this code may shift as part of a broader refactor. |
SashaMalysehko
pushed a commit
to SashaMalysehko/nexus-zkvm
that referenced
this pull request
Dec 9, 2025
* Fix benchmark pathing. * Formatting. * Another path fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes unnecessary cloning when converting PrecompilePath to SerializablePath in generate_statics. The as_syn_path() method only needs a reference, so we can pass &PrecompilePath directly.
Changes