Skip to content

fix: remove unnecessary clone in generate_statics #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeVikingMark wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: remove unnecessary clone in generate_statics #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2e8304
Update precompile_path.rs
DeVikingMark Dec 6, 2025
964c599
Update generation.rs
DeVikingMark Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion precompiles/macros/src/generation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ pub(crate) fn generate_statics(paths: &Vec<PrecompilePath>) -> Result<TokenStrea

for (i, path) in (0..num_precompiles).zip(paths) {
let symbol_name = Ident::new(&format!("{PRECOMPILE_SYMBOL_PREFIX}{i}"), Span::call_site());
let serializable_path = SerializablePath::from((*path).clone());
let serializable_path = SerializablePath::from(path);
let data = match serde_json::to_string(&serializable_path) {
Err(e) => {
return Err(syn::Error::new(
Expand Down
6 changes: 6 additions & 0 deletions precompiles/macros/src/precompile_path.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,3 +138,9 @@ impl From<PrecompilePath> for SerializablePath {
Self(path.as_syn_path())
}
}

impl From<&PrecompilePath> for SerializablePath {
fn from(path: &PrecompilePath) -> Self {
Self(path.as_syn_path())
}
}