Skip to content

Json schema improvements #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreirie merged 11 commits into from
Mar 26, 2025
Merged

Json schema improvements #469

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
571d7eb
Merge pull request #410 from nf-core/dev
jasmezz Aug 27, 2024
66e7a33
Merge pull request #413 from nf-core/dev
jasmezz Sep 5, 2024
ed9af9d
Merge pull request #456 from nf-core/dev
jfy133 Mar 5, 2025
3d9fffa
Merge branch 'nf-core:master' into json-schema-improvements
andreirie Mar 24, 2025
a631806
Changed descriptions from 'nextflow_schema.json' and 'schema_input.js…
andreirie Mar 25, 2025
e96be7b
Updated changelog
andreirie Mar 25, 2025
bd45649
Updated CHANGELOG.md
andreirie Mar 25, 2025
c83c2fc
bump changelog
andreirie Mar 26, 2025
6c9d13f
Bump changelog
andreirie Mar 26, 2025
6a2c09b
Fixed changelog
andreirie Mar 26, 2025
079f217
Fixed changelod
andreirie Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v2.2.0dev - [date]
## v2.3.0 - dev - [date]
Copy link
Copy Markdown

@jen-reeve jen-reeve Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you aren't releasing a new version, just adding to whatever the next release is, you don't need to set up a new dev tag. Just leave #v2.2.0dev and include your changes there. Typically, a new release will include more than just some tidying up. See the recent Sarek JSON improvement PR for an example.

Copy link
Copy Markdown
Contributor Author

@andreirie andreirie Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the advice.


### `Added`

Expand All @@ -13,6 +13,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### `Deprecated`

## v2.2.0 - André Cidade - [2025-3-25]

### `Added`

### `Fixed`

- [#469](https://github.com/nf-core/funcscan/pull/469) Changed descriptions from 'nextflow_schema.json' and 'schema_input.json'.

### `Dependencies`

### `Deprecated`

## v2.1.0 - Egyptian Koshari - [2025-03-05]

### `Added`
Expand Down
2 changes: 1 addition & 1 deletion assets/schema_input.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"sample": {
"type": "string",
"pattern": "^\\S+$",
"errorMessage": "Sample name must be provided and cannot contain spaces",
"errorMessage": "Sample ID must be provided, must be an integer or string and cannot contain spaces",
"meta": ["id"]
},
"fasta": {
Expand Down
5 changes: 2 additions & 3 deletions nextflow_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@
"description": "MultiQC report title. Printed as page header, used for filename if not otherwise specified.",
"fa_icon": "fas fa-file-signature"
}
},
"help_text": ""
}
},
"screening_type_activation": {
"title": "Screening type activation",
Expand Down Expand Up @@ -1408,7 +1407,7 @@
"description": "The p-value cutoff for protein domains to be included.",
"fa_icon": "fas fa-filter",
"default": 1e-9,
"help_text": "The p-value cutoff for protein domains to be included.\n\nFor more information see the GECCO [documentation](https://github.com/zellerlab/GECCO).\n\n> Modifies tool parameter(s):\n> - GECCO: `--pfilter`"
"help_text": "For more information see the GECCO [documentation](https://github.com/zellerlab/GECCO).\n\n> Modifies tool parameter(s):\n> - GECCO: `--pfilter`"
},
"bgc_gecco_threshold": {
"type": "number",
Expand Down
Loading