Skip to content

Json schema improvements#469

Merged
andreirie merged 11 commits intonf-core:devfrom
andreirie:json-schema-improvements
Mar 26, 2025
Merged

Json schema improvements#469
andreirie merged 11 commits intonf-core:devfrom
andreirie:json-schema-improvements

Conversation

@andreirie
Copy link
Contributor

@andreirie andreirie commented Mar 25, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/funcscan branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @andreirie,

It looks like this pull-request is has been made against the andreirie/funcscan master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the andreirie/funcscan dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@andreirie andreirie changed the base branch from master to dev March 25, 2025 16:38
@jen-reeve jen-reeve linked an issue Mar 25, 2025 that may be closed by this pull request
15 tasks
CHANGELOG.md Outdated
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v2.2.0dev - [date]
## v2.3.0 - dev - [date]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you aren't releasing a new version, just adding to whatever the next release is, you don't need to set up a new dev tag. Just leave #v2.2.0dev and include your changes there. Typically, a new release will include more than just some tidying up. See the recent Sarek JSON improvement PR for an example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the advice.

CHANGELOG.md Outdated
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v2.2.0dev - [date]
## v2.1.1 - Brazilian André - [date]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## v2.1.1 - Brazilian André - [date]
## v2.2.0dev - [date]

Copy link

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, please ping me on Slack if you have fixed it

Copy link

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andreirie andreirie merged commit 29c1fad into nf-core:dev Mar 26, 2025
22 of 29 checks passed
@andreirie andreirie deleted the json-schema-improvements branch March 26, 2025 16:37
@jasmezz jasmezz mentioned this pull request Sep 18, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON schema: Funcscan

5 participants