Skip to content

Revert CheckM2 database download workaround and update modules#1011

Merged
dialvarezs merged 2 commits into
nf-core:devfrom
dialvarezs:update-checkm2
Apr 6, 2026
Merged

Revert CheckM2 database download workaround and update modules#1011
dialvarezs merged 2 commits into
nf-core:devfrom
dialvarezs:update-checkm2

Conversation

@dialvarezs

@dialvarezs dialvarezs commented Apr 2, 2026

Copy link
Copy Markdown
Member

This PR updates CheckM2 modules to newer versions using topics.
And also reverts the workaround introduced in #966 since it's no longer necessary, because the module was patched to set the UA in nf-core/modules#9744

But, more importantly, the workaround introduced a bug that we didn't notice: the CheckM2 database channel was being consumed after one process, so CheckM2 (and so GTDB-TK that depends on the Bin QC channel) was effectively executing only for one bin/unbin set.

I detected this recently looking at full tests runs on Seqera Cloud:
image
You see only 1 CheckM2 and 0 GTDB-Tk jobs because CheckM2 processed an "unbin" set, so it didn't make the cut for the qc threshold.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@dialvarezs dialvarezs changed the title fix: Revert CheckM2 database download fix and update modules Revert CheckM2 database download workaround and update modules Apr 4, 2026
@dialvarezs dialvarezs merged commit 77ea24b into nf-core:dev Apr 6, 2026
24 checks passed
dialvarezs added a commit that referenced this pull request Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants