Revert CheckM2 database download workaround and update modules#1011
Merged
Conversation
prototaxites
approved these changes
Apr 6, 2026
dialvarezs
added a commit
that referenced
this pull request
Apr 6, 2026
Forgotten changelog for #1011
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates CheckM2 modules to newer versions using topics.
And also reverts the workaround introduced in #966 since it's no longer necessary, because the module was patched to set the UA in nf-core/modules#9744
But, more importantly, the workaround introduced a bug that we didn't notice: the CheckM2 database channel was being consumed after one process, so CheckM2 (and so GTDB-TK that depends on the Bin QC channel) was effectively executing only for one bin/unbin set.
I detected this recently looking at full tests runs on Seqera Cloud:

You see only 1 CheckM2 and 0 GTDB-Tk jobs because CheckM2 processed an "unbin" set, so it didn't make the cut for the qc threshold.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).