Skip to content

Prevent running ALE on long read data#1017

Merged
dialvarezs merged 2 commits into
nf-core:devfrom
dialvarezs:fix/prevent-ale-on-longreads
Apr 9, 2026
Merged

Prevent running ALE on long read data#1017
dialvarezs merged 2 commits into
nf-core:devfrom
dialvarezs:fix/prevent-ale-on-longreads

Conversation

@dialvarezs

Copy link
Copy Markdown
Member

Right now we were depending on a filter on sr_platform to determine if ALE should be run for an assembly.
The problem with this is that if a sample has both longread and shortread data, it will run for the LR assembly too, failing as we have seen in the full tests.
The solution is to just use ch_shortread_assemblies instead.

Fixes #974.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@prototaxites prototaxites left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't seem to be able to delete this, I was going to mention the changelog

@dialvarezs dialvarezs changed the title fix: prevent running ALE on long read data Prevent running ALE on long read data Apr 9, 2026
@dialvarezs dialvarezs merged commit ed1ce51 into nf-core:dev Apr 9, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants