Skip to content

Fix catpack on unbins and ignore catpack/summarise errors#1019

Merged
dialvarezs merged 10 commits into
nf-core:devfrom
dialvarezs:fix/catpack-summarise-errors
Apr 15, 2026
Merged

Fix catpack on unbins and ignore catpack/summarise errors#1019
dialvarezs merged 10 commits into
nf-core:devfrom
dialvarezs:fix/catpack-summarise-errors

Conversation

@dialvarezs

@dialvarezs dialvarezs commented Apr 9, 2026

Copy link
Copy Markdown
Member

These are two fixes (kinda), both mentioned in #870

For the CAT_pack summarise error
More than a fix, this is a workaround, because this a limitation from CAT_pack side: MGXlab/CAT_pack#125

For the CAT_pack errors on unbinned data
The problem here was that when using catpack/contigs for the classification, we were passing it the split me make for publishing instead of the single file. This PR adds a concatenation step before that to prevent the error.

Closes #870.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@dialvarezs dialvarezs changed the title Ignore errors on catpack/summarise Fix catpack on unbins and ignore catpack/summarise errors Apr 9, 2026
@jfy133

jfy133 commented Apr 15, 2026

Copy link
Copy Markdown
Member

Thanks @dialvarezs !

@dialvarezs dialvarezs merged commit 0aacd40 into nf-core:dev Apr 15, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants