Skip to content

Update concoct subworkflow and modules#1020

Merged
dialvarezs merged 2 commits into
nf-core:devfrom
dialvarezs:bumps/concoct-subwf
Apr 9, 2026
Merged

Update concoct subworkflow and modules#1020
dialvarezs merged 2 commits into
nf-core:devfrom
dialvarezs:bumps/concoct-subwf

Conversation

@dialvarezs

Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things look iffy to me from the modules themselves...

Comment thread modules/nf-core/concoct/concoct/meta.yml
{
"id": "test2"
},
"test2.tsv:md5,3e0e31b009b3f4b4345df615a70a2835"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where have we these gone?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sanitizeOutput() it is. Removes the number-indexed sections from the snapshot, keeping only named ones, to make the snapshot cleaner and less redundant.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok!

@jfy133 jfy133 self-requested a review April 9, 2026 19:54
@dialvarezs dialvarezs merged commit 1a5978a into nf-core:dev Apr 9, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants