Fix hybrid co-assembly with SPAdes#1032
Conversation
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.5.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
jfy133
left a comment
There was a problem hiding this comment.
LGTM, but could you add a test 😅, now that we have the testing framework implemented:)
Hm, well, I'm going to test how much resources SPAdes hybrid co-assembly needs with the data as described in #1031 (comment). |
If we are still building it, now would be the time to tweak it to at the second sample (imo)! |
dialvarezs
left a comment
There was a problem hiding this comment.
I'm doing the setup to test co-assembly + hybrid and I reproduced the issue.
I'm going to merge this now, and follow-up in the hybrid snapshot PR with the updated samplesheet and profile to cover this.
Fix #1031
Essentially,
meta.single_endwas missing for long reads that were about to be pooled withPOOL_LONG_READS(that is the nf-core moduleCAT_FASTQ). This is added here at the appropriate point.Afaik there is no test config that makes sure that problem is tested.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).