Skip to content

Fix hybrid co-assembly with SPAdes#1032

Merged
dialvarezs merged 1 commit into
nf-core:devfrom
d4straub:fix-hybrid-coassembly-dev
May 14, 2026
Merged

Fix hybrid co-assembly with SPAdes#1032
dialvarezs merged 1 commit into
nf-core:devfrom
d4straub:fix-hybrid-coassembly-dev

Conversation

@d4straub

@d4straub d4straub commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Fix #1031

Essentially, meta.single_end was missing for long reads that were about to be pooled with POOL_LONG_READS (that is the nf-core module CAT_FASTQ). This is added here at the appropriate point.

Afaik there is no test config that makes sure that problem is tested.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot

Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@jfy133 jfy133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you add a test 😅, now that we have the testing framework implemented:)

@d4straub

d4straub commented May 4, 2026

Copy link
Copy Markdown
Collaborator Author

but could you add a test

Hm, well, test_hybrid is almost there, that is already in the work in #1029. coassemble_group = true and a second sample is missing though to catch that issue. Currently there is no second long reads file in mag test datasets.

I'm going to test how much resources SPAdes hybrid co-assembly needs with the data as described in #1031 (comment).
Edit: resources seem no issue!

@jfy133

jfy133 commented May 5, 2026

Copy link
Copy Markdown
Member

but could you add a test

Hm, well, test_hybrid is almost there, that is already in the work in #1029. coassemble_group = true and a second sample is missing though to catch that issue. Currently there is no second long reads file in mag test datasets.

I'm going to test how much resources SPAdes hybrid co-assembly needs with the data as described in #1031 (comment).
Edit: resources seem no issue!

If we are still building it, now would be the time to tweak it to at the second sample (imo)!

@dialvarezs dialvarezs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm doing the setup to test co-assembly + hybrid and I reproduced the issue.
I'm going to merge this now, and follow-up in the hybrid snapshot PR with the updated samplesheet and profile to cover this.

@dialvarezs dialvarezs merged commit c1d44be into nf-core:dev May 14, 2026
25 checks passed
@d4straub d4straub deleted the fix-hybrid-coassembly-dev branch May 15, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants