fix: gzipped files on METABINNER_BINS to prevent race condition#1058
Open
dialvarezs wants to merge 3 commits into
Open
fix: gzipped files on METABINNER_BINS to prevent race condition#1058dialvarezs wants to merge 3 commits into
dialvarezs wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running MetaBinner on our HPC (storage mounted via NFS), I got the following error:
This happens because when find starts, the file is still visible in the NFS filesystem, but by the time the
mvcommand runs, the file has already been unlinked, throwing an error.This chamge makes the script generating the bin files gzipped, so the post-execution of gzip and mv is no longer required.
This also changes the boundary of too short bins (
<to<=) to align with what the tool does.PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).