Add REGENIE step1 and step2 modules with Wave containers and expanded GWAS tests#10800
Open
lyh970817 wants to merge 7 commits intonf-core:masterfrom
Open
Add REGENIE step1 and step2 modules with Wave containers and expanded GWAS tests#10800lyh970817 wants to merge 7 commits intonf-core:masterfrom
lyh970817 wants to merge 7 commits intonf-core:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new nf-core module implementations for running REGENIE GWAS in two stages (step1 model fitting and step2 association testing), including Wave-backed containers and nf-test coverage for quantitative/binary phenotypes with covariates and step2 consumption of step1 predictions.
Changes:
- Introduce
regenie/step1andregenie/step2modules (Nextflow process, meta.yml, conda env, Wave containers). - Add nf-test suites + snapshots for quantitative/binary PLINK1 runs with covariates, plus stubbed PLINK2 scenarios.
- Add per-test
modules_testdata_base_pathconfig to use upstream module test datasets.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/nf-core/regenie/step1/main.nf | Implements REGENIE step1 process emitting prediction list + LOCO files |
| modules/nf-core/regenie/step1/meta.yml | Declares step1 module I/O contract, containers, and versions topic |
| modules/nf-core/regenie/step1/environment.yml | Conda environment for REGENIE 4.1.2 |
| modules/nf-core/regenie/step1/tests/main.nf.test | nf-test cases for quantitative/binary + stub mode |
| modules/nf-core/regenie/step1/tests/main.nf.test.snap | Snapshot expectations for step1 tests |
| modules/nf-core/regenie/step1/tests/nextflow.config | Testdata base path configuration |
| modules/nf-core/regenie/step2/main.nf | Implements REGENIE step2 association testing consuming step1 predictions |
| modules/nf-core/regenie/step2/meta.yml | Declares step2 module I/O contract, containers, and versions topic |
| modules/nf-core/regenie/step2/environment.yml | Conda environment for REGENIE 4.1.2 |
| modules/nf-core/regenie/step2/tests/main.nf.test | nf-test cases validating step2 with step1-produced predictions + stub mode |
| modules/nf-core/regenie/step2/tests/main.nf.test.snap | Snapshot expectations for step2 tests |
| modules/nf-core/regenie/step2/tests/nextflow.config | Testdata base path configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| input: | ||
| tuple val(meta), path(plink_genotype_file), path(plink_variant_file), path(plink_sample_file) | ||
| tuple val(meta2), path(pheno) | ||
| tuple val(meta3), path(covar) |
| tuple val(meta), path(plink_genotype_file), path(plink_variant_file), path(plink_sample_file) | ||
| tuple val(meta2), path(pheno) | ||
| tuple val(meta3), path(predictions), path(loco_files) | ||
| tuple val(meta4), path(covar) |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
regenie/step1andregenie/step2with Wave-backed containers and GWAS-focused tests covering quantitative and binary phenotypes, covariates, andstep2consumption of setup-generatedstep1predictions. The shared test data needed for these tests is now merged upstream in nf-core/test-datasets#1919.PR checklist
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda