Skip to content

Remove non-standard ext keys from jupyternotebook#10895

Merged
SPPearce merged 3 commits intonf-core:masterfrom
mahesh-panchal:fix/jupyternotebook-ext-compliance
Mar 19, 2026
Merged

Remove non-standard ext keys from jupyternotebook#10895
SPPearce merged 3 commits intonf-core:masterfrom
mahesh-panchal:fix/jupyternotebook-ext-compliance

Conversation

@mahesh-panchal
Copy link
Member

@mahesh-panchal mahesh-panchal commented Mar 13, 2026

PR checklist

Part of #8716

  • Removes non-standard keys.
  • Models implementation after QUARTONOTEBOOK.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@SPPearce SPPearce added this pull request to the merge queue Mar 19, 2026
Merged via the queue into nf-core:master with commit 32a98ce Mar 19, 2026
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants