Skip to content

Update files for MLST tests #8388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

acvander
Copy link

@acvander acvander commented May 1, 2025

This PR fixes failing tests for MLST by updating to a new input file. The previous file had been deleted from the test-datasets repository.

PR checklist

Closes #8152

  • [ x ] This comment contains a description of changes (with reason).
  • [ x ] If you've fixed a bug or added code that should be tested, add tests!
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [ x ] nf-core modules test <MODULE> --profile docker
      • [ x ] nf-core modules test <MODULE> --profile singularity
      • [ x ] nf-core modules test <MODULE> --profile conda

- updating test file to another file in test-datasets
- updating snapshots
@@ -16,7 +16,7 @@ nextflow_process {
process {
"""
input[0] = [ [ id:'test', single_end:false ], // meta map
file("https://raw.githubusercontent.com/nf-core/test-datasets/bactmap/genome/NCTC13799.fna", checkIfExists: true)
file("https://raw.githubusercontent.com/nf-core/test-datasets/modules/data/genomics/prokaryotes/bacteroides_fragilis/genome/genome.fna.gz", checkIfExists: true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the path to not use raw.github... (see other modules for reference) :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the path to match the nf-core pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MLST Unit Tests Fail
2 participants