Skip to content

Conversation

@georgiakes
Copy link
Member

@georgiakes georgiakes commented Jan 15, 2026

PR checklist

Module for the tmb tool

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@georgiakes georgiakes added the new module Adding a new module label Jan 15, 2026
@georgiakes
Copy link
Member Author

Even though I run
nf-core modules lint tmb/pytmb --fix
The linting error still persists but I'm not sure why.

@maxulysse
Copy link
Member

Even though I run nf-core modules lint tmb/pytmb --fix The linting error still persists but I'm not sure why.

I think you need to run it with the dev version

@georgiakes
Copy link
Member Author

Still the same :(
image

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've had a discussion in the past about including small test files like these yml files in the tests folder; personally I think it is a good idea but it was not in consensus.
You can make this kind of file on the fly inside the nf-test though, like this: https://github.com/nf-core/modules/blob/master/modules/nf-core/ngscheckmate/ncm/tests/main.nf.test#L58

@georgiakes
Copy link
Member Author

We've had a discussion in the past about including small test files like these yml files in the tests folder; personally I think it is a good idea but it was not in consensus. You can make this kind of file on the fly inside the nf-test though, like this: https://github.com/nf-core/modules/blob/master/modules/nf-core/ngscheckmate/ncm/tests/main.nf.test#L58

I'm not sure I completely understand, but the creation of the yml files are not created by another module and that is why I've included them on the tests folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants