Skip to content

Conversation

@prototaxites
Copy link
Contributor

@prototaxites prototaxites commented Jan 15, 2026

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@prototaxites prototaxites marked this pull request as draft January 15, 2026 13:58
@prototaxites prototaxites marked this pull request as ready for review January 15, 2026 15:51
Groovy Map containing sample information
e.g. [ id:'test', single_end:false ]
- "*.ktab*":
- '"*.ktab*", hidden: true':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried "*.ktab*" on my computer and the linting went without error. Is it really needed to hide something here?

Copy link
Contributor Author

@prototaxites prototaxites Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be a regression in the dev version of tools: https://nfcore.slack.com/archives/CE5LG7WMB/p1768480946931369

I agree we should just use *.ktab* here ideally! But we do need to capture the hidden files in the module as the kmer databases consist of a normal index file and N hidden files with a . prefix.

Groovy Map containing sample information
e.g. [ id:'test', single_end:false ]
- "*.{prof,pidx}*":
- '"*.{prof,pidx}*", hidden: true':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, is hidden: true really needed?

then {
assertAll(
{ assert process.success },
{ assert snapshot(process.out).match() }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried in my computer with { assert snapshot(process.out).match() } and it works fine. Is it really needed to check each output channel one by one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was also passing fine locally on my computer, but the snapshot was not stable when run on CI. I think the merging of two tables is non-deterministic in some way that might depend on e.g. the locale...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants