snpeff and vep - topics for reports #9677
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
nvnieuwk
reviewed
Jan 16, 2026
Comment on lines
+17
to
+19
| tuple val(meta), val('snpeff'), path("*.csv"), topic: reports, emit: report | ||
| tuple val(meta), val('snpeff'), path("*.html"), topic: reports, emit: summary_html | ||
| tuple val(meta), val('snpeff'), path("*.genes.txt"), topic: reports, emit: genes_txt |
Contributor
There was a problem hiding this comment.
Having the tool name in here would be quite annoying I think. I'd rather have a proper discussion with core/maintainers before we start making these changes if that's okay for you
Member
Author
There was a problem hiding this comment.
That's why I did the PR, to start a discussion
Member
Author
There was a problem hiding this comment.
I actually tried to put this into the meta map, but failed miserably
Contributor
There was a problem hiding this comment.
What is the reason to leave this in? MultiQC doesn't need it, right?
Member
Author
There was a problem hiding this comment.
I need it to know which tools it's coming from for when I want to publish the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To just simplify the publication of files via workflow output that are not used in downstream process in pipelines (ie generally fed to multiqc via reports)
cf nf-core/rnavar#277
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda