Fix --help with strict syntax mode
#9680
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix parsing error from Nextflow strict syntax mode, affecting a bunch of pipelines. See nf-core/rnavar#278 for initial repro and fix. See also nf-core/tools#3986
maxulysse
approved these changes
Jan 16, 2026
mashehu
reviewed
Jan 16, 2026
| log.info paramsHelp( | ||
| help_options, | ||
| params.help instanceof String ? params.help : "", | ||
| (params.help instanceof String && params.help != "true") ? params.help : "", |
Contributor
There was a problem hiding this comment.
Suggested change
| (params.help instanceof String && params.help != "true") ? params.help : "", | |
| (params.help instanceof String && params.help = "true") ? params.help : "", |
If I don't misunderstand what is happening here.
Member
Author
There was a problem hiding this comment.
No I don't think that's right. It's checking to see if it's just the flag or whether a string was passed. If it's just a flag and it's coerced into a string it'll be a string "true", and we don't want to print that. Otherwise we do.
I think that's right?
Member
Author
There was a problem hiding this comment.
Written out logic:
if ( (params.help is a string) and (params.help is not "true") ){
return params.help (whatever it is, some string)
} else {
return an empty string
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parsing error from Nextflow strict syntax mode, affecting a bunch of pipelines.
See nf-core/rnavar#278 for initial repro and fix.
See also nf-core/tools#3986