Skip to content

Release 2.2.0#243

Merged
scwatts merged 92 commits into
masterfrom
dev
Sep 2, 2025
Merged

Release 2.2.0#243
scwatts merged 92 commits into
masterfrom
dev

Conversation

@scwatts
Copy link
Copy Markdown
Member

@scwatts scwatts commented Aug 26, 2025

No description provided.

scwatts and others added 30 commits June 4, 2024 16:52
Co-authored-by: Stephen Watts <scwatts@users.noreply.github.com>
…ionableCodingPanel and CoverageCodingPanel files
scwatts and others added 13 commits August 13, 2025 21:26
Force install of compatible icu version 73.2, the newer 75.1 version
available in conda-forge can be installed with older the r-stringr and
r-stringi recipes but is incompatible.
…or-fastq-data

Support relative paths for fastq data
All WiGiTS tools that accept the log_level argument support the 'OFF'
value except CHORD, which causes oncoanalyser to crash. Therefore, this
log_level / hmftools_log_level value is not allowed.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 26, 2025

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit dedcbe7

+| ✅ 217 tests passed       |+
#| ❔  10 tests were ignored |#
!| ❗  17 tests had warnings |!
Details

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_unchanged - LICENSE does not match the template
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • schema_params - Schema param panel not found from nextflow config
  • schema_params - Schema param fastp_umi_location not found from nextflow config
  • schema_params - Schema param fastp_umi_length not found from nextflow config
  • schema_params - Schema param fastp_umi_skip not found from nextflow config
  • schema_params - Schema param redux_umi_duplex_delim not found from nextflow config
  • schema_params - Schema param genome_version not found from nextflow config
  • schema_params - Schema param genome_type not found from nextflow config
  • schema_params - Schema param ref_data_hmf_data_path not found from nextflow config
  • schema_params - Schema param ref_data_panel_data_path not found from nextflow config
  • schema_params - Schema param ref_data_genome_gtf not found from nextflow config
  • schema_params - Schema param ref_data_hla_slice_bed not found from nextflow config
  • schema_description - No description provided in schema for parameter: prepare_reference_only

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.3.2
  • Run at 2025-09-02 02:05:34

@scwatts scwatts requested a review from danilodileo August 26, 2025 06:35
Comment thread README.md
Comment thread docs/usage.md
Comment thread docs/usage/faq_and_troubleshooting.md
Copy link
Copy Markdown

@danilodileo danilodileo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipeline looks well written and organised. I read through the files but I haven't spend too much time since I am not familiar with most of the tools implemented here.
I am testing the pipeline and I will let you know if I encounter major errors/issues.

I have just few comments:

  • As I understood you only have one nf-test for stub mode. shouldn't be good to include more?
  • You have many modules in local. it would be good to consider to move some of them in nf-core/modules since other developers might find it useful.
  • nf-core AWS fill size tests fail. it needs to be fixed

great job!

scwatts and others added 5 commits September 1, 2025 17:31
The GH Action self-hosted RunsOn instances do not have sufficient disk
space to execute non-stub tests (currently 80 GB of EBS volume according
to these docs: https://runs-on.com/configuration/job-labels/#disk). Also
using nf-test tags as providing paths to desired tests is not honoured
when --changed-since is supplied.
Reviewer recommendations and other adjustments
@scwatts
Copy link
Copy Markdown
Member Author

scwatts commented Sep 2, 2025

Thank you for the review @danilodileo!

I've now added the test profile as a new nf-test case. The reason this wasn't initially done is that the GH Action automatically executes all tests, and the runner instances don't have sufficient disk space to store the reference data needed for the test profile (the stub run is configured in such a way that no reference data is required). In order to handle this, I've also set the corresponding GH Action to only execute the stub run; the new test can otherwise be run with nf-test test or similar

We're happy to explore making these tools more easily accessible to the community, though in their current state they are strongly interdependent on one another and running them in a standalone way isn't really possible, so the modules aren't individually that useful to others

I confirmed the AWS full sized test is also failing (though only on manual trigger), and this appears to be caused by some unspecified error during submission of the Seqera Platform job. Looks like it's a known issue with the current advice to ask someone from the nf-core team to trigger the job once the release is completed

@scwatts
Copy link
Copy Markdown
Member Author

scwatts commented Sep 2, 2025

The newly failing GH Action workflow that runs nf-core pipelines download is hitting an error because it uses nf-core/tools from the latest commit on the dev branch and there has recently been a refactor / rework of this feature merged into dev, which appears to have introduced a fatal bug

I have manually tested the nf-core pipelines download command with the most recent release of nf-core/tools (3.3.2; i.e. prior to the download feature refactor) on the changes in this release PR both locally and on another branch (check-tools-download; GH Action job), and each test finished successfully

To confirm this wasn't related to oncoanalyser itself, I also built a minimal reproducible example. See here for more information:

Since the nf-core pipelines download command does work for the changes in this PR when using a release version rather than development version, I will proceed with this release instead of waiting for a fix to be pushed to the dev branch of nf-core/tools

@scwatts scwatts requested a review from ohofmann September 2, 2025 05:59
Copy link
Copy Markdown

@ohofmann ohofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with the proposed changes — thanks for all the work (and the external reviewers).

@scwatts scwatts merged commit b94cbc7 into master Sep 2, 2025
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants