Skip to content

Adding Beagle v5.2#200

Closed
gichas wants to merge 35 commits intonf-core:devfrom
gichas:beagle
Closed

Adding Beagle v5.2#200
gichas wants to merge 35 commits intonf-core:devfrom
gichas:beagle

Conversation

@gichas
Copy link
Copy Markdown

@gichas gichas commented Jul 7, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/phaseimpute branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@LouisLeNezet LouisLeNezet changed the base branch from master to dev July 8, 2025 06:35
@nf-core-bot
Copy link
Copy Markdown
Member

nf-core-bot commented Jul 10, 2025

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.3.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@gichas gichas changed the title Beagle Adding Beagle v5.2 Jul 10, 2025
Copy link
Copy Markdown
Collaborator

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution.
Could you fix it in the same way as the other PR ?

@gichas gichas requested a review from LouisLeNezet July 17, 2025 13:39
Copy link
Copy Markdown
Collaborator

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fine addition to the pipeline.
Here is some comments to improve it.
Could you also update the CHANGELOG in this PR in the same way as the minimac4 PR ?

@gichas gichas requested a review from LouisLeNezet July 20, 2025 18:35
Gaspard ICHAS and others added 7 commits July 21, 2025 10:42
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@LouisLeNezet LouisLeNezet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few update but otherwise good to go !

@LouisLeNezet
Copy link
Copy Markdown
Collaborator

I couldn't merge this PR with the dev branch.
I therefore reproduced it in PR #210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants