-
Notifications
You must be signed in to change notification settings - Fork 61
add saltshaker modules #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
04ea65c
4d4f3d3
3194ef6
f6d090a
f8fb561
2d378e1
73b4d69
ce2e982
4a552dd
21b34d2
b749028
e78c61e
a1d4566
3b74a51
933333c
58a6eed
0727789
cd961e0
0055bb5
144bfa2
553cddc
5dcbc15
7dc333d
2f32354
7c5ed4f
ed64d2b
37a053f
c9ebe12
180bdf3
70663fb
bddcceb
fc6c809
5df75fc
af41859
493a43a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could this be an nf-core module ? And have tests ?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes! will do :) |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this should be in the templates directory ? https://nf-co.re/docs/guidelines/components/modules#module-template-location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nextflow docs say that templates are discouraged and should only be used for bash scripts (https://www.nextflow.io/docs/latest/process.html#template) which is why I went with the bin. We can discuss more and see what nf-core folks think when/if this becomes an nf-core module