Skip to content

Fusionreport Fixes (Cosmic etc pp)#815

Merged
apeltzer merged 19 commits into
devfrom
fix-fusion-report
May 28, 2026
Merged

Fusionreport Fixes (Cosmic etc pp)#815
apeltzer merged 19 commits into
devfrom
fix-fusion-report

Conversation

@apeltzer

@apeltzer apeltzer commented May 27, 2026

Copy link
Copy Markdown
Member

This fixes multiple things with fusionreport, e.g. the issues with latest COSMIC versions.

Closes #797

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnafusion branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f7b8cd9

+| ✅ 314 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   3 tests had warnings |!
Details

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config
  • pipeline_todos - TODO string in CONTRIBUTING.md: Add any pipeline specific contribution guidelines here, such as coding styles, procedures, checklists etc.

❔ Tests ignored:

  • files_exist - File is ignored: tests/default.nf.test
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.2
  • Run at 2026-05-28 13:19:11

@apeltzer

Copy link
Copy Markdown
Member Author

Testing here was successfull, COSMIC IDs are again working fine:

image

@apeltzer apeltzer marked this pull request as ready for review May 27, 2026 18:27
@apeltzer apeltzer changed the title Fusionreport Fixes (Cosmic etc pp) -- still testing Fusionreport Fixes (Cosmic etc pp) May 28, 2026
@apeltzer apeltzer merged commit 3934e6b into dev May 28, 2026
20 checks passed
@apeltzer apeltzer deleted the fix-fusion-report branch May 28, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants