ci(nf-test): align actions/checkout SHA across pipeline workflows - #1848
Merged
Conversation
Bumps actions/checkout in nf-test-arm.yml (v5) and nf-test-gpu.yml (v4) to the same SHA used by the template-derived nf-test.yml (v6, de0fac2e4500dabe0009e67214ff5f5447ce83dd). nf-test.yml unchanged. Refs #1847.
|
mashehu
approved these changes
May 8, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1847 (Task 1 only — see "Task 2 status" below).
Bumps
actions/checkoutin the pipeline-specific nf-test workflows so all three workflows use the same SHA-pinnedv6that the template-derivednf-test.ymlalready pins:.github/workflows/nf-test-arm.yml(lines 43, 93):v5→v6(de0fac2e4500dabe0009e67214ff5f5447ce83dd).github/workflows/nf-test-gpu.yml(lines 40, 85):v4→v6(same SHA).github/workflows/nf-test.yml: unchanged (alreadyv6, template-owned)No other action drift between the three workflows: the shared composite actions (
./.github/actions/get-shards,./.github/actions/nf-test) covernf-core/setup-nextflow,actions/setup-python,nf-core/setup-nf-test,eWaterCycle/setup-apptainer,conda-incubator/setup-miniconda, so all three callers get identical pins.Task 2 status (snapshot timestamp stripping)
The original issue proposed a second task: strip the
timestampfield from savedtests/*.nf.test.snapfiles via annf-test.configsnapshot.excludeoption, with a fallback of post-processing if no such option exists. I checked the nf-test 0.9.5 source:SnapshotFileItemhardcodestimestampviaDateTimeFormatter.ISO_DATE_TIME.format(LocalDateTime.now())andSnapshotFile#createJsonGeneratoronly excludesmappingfrom the JSON output. There is no config-level option today, and no upstream issue tracking one. The post-processing fallback (jq/python strip) would diverge from what nf-test writes on every regen and adds maintenance burden, so I'm not pursuing it here.Task 2 is therefore deferred. Will follow up with an upstream feature request against
askimed/nf-testand link it from #1847 once it's filed.Test plan
Run nf-test on ARMworkflow runs green on this PR (exercises the newactions/checkout@v6SHA).Run GPU nf-testsworkflow runs green on this PR.Run nf-test(CPU) workflow runs green — sanity check, unchanged.