Skip to content

fix(gtffilter): add support for non-Ensembl GTF biotype attributes (#1886) - #1889

Closed
kanishkanandhkumar wants to merge 2 commits into
nf-core:devfrom
kanishkanandhkumar:feature/non-ensembl-gtf-support
Closed

fix(gtffilter): add support for non-Ensembl GTF biotype attributes (#1886)#1889
kanishkanandhkumar wants to merge 2 commits into
nf-core:devfrom
kanishkanandhkumar:feature/non-ensembl-gtf-support

Conversation

@kanishkanandhkumar

Copy link
Copy Markdown

Description of the change

This PR resolves an issue where non-Ensembl annotation files (e.g., NCBI, RefSeq, GENCODE) fail during GTF filtering because child features (exon) lack explicit gene_biotype or gene_type attributes.

Changes made:

  • Updated modules/nf-core/custom/gtffilter/templates/gtffilter.py with a two-pass parsing strategy.
  • Added key aliasing for biotype attribute variants (gene_biotype, gene_type, biotype, transcript_biotype, transcript_type).
  • Implemented parent-to-child attribute inheritance so exons inherit gene_biotype from their parent gene/transcript entries when omitted.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

@github-actions

Copy link
Copy Markdown

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @kanishkanandhkumar,

It looks like this pull-request is has been made against the kanishkanandhkumar/rnaseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the kanishkanandhkumar/rnaseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@kanishkanandhkumar

Copy link
Copy Markdown
Author

@nf-core-bot fix linting

@kanishkanandhkumar
kanishkanandhkumar changed the base branch from master to dev July 21, 2026 04:05
@kanishkanandhkumar
kanishkanandhkumar force-pushed the feature/non-ensembl-gtf-support branch from 7dae075 to 6aa08c4 Compare July 21, 2026 05:02
@kanishkanandhkumar kanishkanandhkumar closed this by deleting the head repository Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant