Draft
Conversation
Patch Release 3.7.1
- Add ploidy column to input schema (integer, default: 2, min: 1) - Pass ploidy to HaplotypeCaller via --sample-ploidy in ext.args - Default ploidy is 2 for diploid organisms (human, mouse, etc.) - Add test profiles and CSV files for haploid (ploidy=1) and triploid (ploidy=3) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
VCFtools TsTv calculations do not support polyploid genotypes. Skip VCFTOOLS processes when sample ploidy exceeds 2. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[DRAFT]: Add per-sample ploidy support for HaplotypeCaller
Summary
ploidycolumn to input schema (integer, default: 2, minimum: 1)--sample-ploidyin ext.argsDiscussion: Per-sample vs global ploidy
This PR introduces per-sample ploidy via the input CSV. This differs from existing global parameters like
ascat_ploidyandcf_ploidy.Per-sample ploidy (CSV input):
Global ploidy (parameters):
ascat_ploidyto override optimization), ControlFREEC (cf_ploidy"type": "string")Questions for maintainers:
Changes
assets/schema_input.jsonconf/modules/haplotypecaller.config--sample-ploidyto GATK4_HAPLOTYPECALLERconf/modules/modules.configconf/test/tools_germline_haploid.configconf/test/tools_germline_triploid.confignextflow.configtests/csv/3.0/recalibrated_germline_*.csvTest plan
Test haploid sample (ploidy=1):
nextflow run . -profile test,tools_germline_haploid,docker \ --outdir results_haploid \ --tools haplotypecaller \ --skip_tools haplotypecaller_filter \ -resumeTest triploid sample (ploidy=3):
nextflow run . -profile test,tools_germline_triploid,docker \ --outdir results_triploid \ --tools haplotypecaller \ --skip_tools haplotypecaller_filter \ -resumeVerify VCFtools is skipped for triploid samples
Verify default ploidy=2 works for existing pipelines (backwards compatible:
nextflow run . -profile test,docker --outdir <OUTDIR>).PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).