Skip to content

Fix bugs in qc_bam and prepare_genome subworkflows and add tests#162

Merged
beatrizsavinhas merged 28 commits into
nf-core:devfrom
beatrizsavinhas:test-prepare-genome
Dec 9, 2025
Merged

Fix bugs in qc_bam and prepare_genome subworkflows and add tests#162
beatrizsavinhas merged 28 commits into
nf-core:devfrom
beatrizsavinhas:test-prepare-genome

Conversation

@beatrizsavinhas

@beatrizsavinhas beatrizsavinhas commented Dec 2, 2025

Copy link
Copy Markdown
Contributor
  • Fix bug where the output files from picard_collectmultiplemetrics, run in subworkflow QC_BAM were not being passed to ch_multiqc_files (only the files from picard_collecthsmetrics were collected).

    ch_multiqc_files = ch_multiqc_files.mix(QC_BAM.out.hs_metrics)

  • Fix bug in mandatory subworkflow PREPARE_GENOME where the input channel was set to an empty channel which caused the subworkflow to be skipped when running the pipeline.

    ch_reference_fasta = channel.empty()

  • Add tests for subworkflow PREPARE_GENOME.

  • Updated shapshots for existing pipeline tests.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/seqinspector branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@beatrizsavinhas beatrizsavinhas changed the title Fix bug in prepare_genome and add tests Fix prepare_genome subworkflow and add tests Dec 2, 2025
@beatrizsavinhas beatrizsavinhas marked this pull request as ready for review December 2, 2025 11:02

@MatthiasZepper MatthiasZepper left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I appreciate that you have added additional tests in the process and of course that bug needs to be corrected.

I suggest making the test data configurable, but this is not mandatory at this point, because I think, we will have to refactor all the tests anyway prior to a release...

Comment thread subworkflows/local/prepare_genome/tests/main.nf.test Outdated
@beatrizsavinhas beatrizsavinhas changed the title Fix prepare_genome subworkflow and add tests Fix bugs in qc_bam and prepare_genome subworkflows and add tests Dec 4, 2025

@maxulysse maxulysse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for pushing commit to your branch without warning, but wanted to solve merge conflicts

@beatrizsavinhas

Copy link
Copy Markdown
Contributor Author

Ah thanks for fixing it @maxulysse! I was awaiting a second review since I had changed some things after the first review but now that you have also approved it, I will merge the PR!

@beatrizsavinhas beatrizsavinhas merged commit ad7a449 into nf-core:dev Dec 9, 2025
20 checks passed
@beatrizsavinhas beatrizsavinhas deleted the test-prepare-genome branch December 9, 2025 08:20
maxulysse pushed a commit that referenced this pull request Jan 13, 2026
Fix bugs in qc_bam and prepare_genome subworkflows and add tests to the latter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants