Fix bugs in qc_bam and prepare_genome subworkflows and add tests#162
Merged
beatrizsavinhas merged 28 commits intoDec 9, 2025
Conversation
added 13 commits
December 2, 2025 12:05
MatthiasZepper
approved these changes
Dec 3, 2025
MatthiasZepper
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution. I appreciate that you have added additional tests in the process and of course that bug needs to be corrected.
I suggest making the test data configurable, but this is not mandatory at this point, because I think, we will have to refactor all the tests anyway prior to a release...
maxulysse
approved these changes
Dec 8, 2025
Contributor
Author
|
Ah thanks for fixing it @maxulysse! I was awaiting a second review since I had changed some things after the first review but now that you have also approved it, I will merge the PR! |
maxulysse
pushed a commit
that referenced
this pull request
Jan 13, 2026
Fix bugs in qc_bam and prepare_genome subworkflows and add tests to the latter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug where the output files from
picard_collectmultiplemetrics, run in subworkflowQC_BAMwere not being passed toch_multiqc_files(only the files frompicard_collecthsmetricswere collected).seqinspector/workflows/seqinspector.nf
Line 171 in 07e8f87
Fix bug in mandatory subworkflow
PREPARE_GENOMEwhere the input channel was set to an empty channel which caused the subworkflow to be skipped when running the pipeline.seqinspector/subworkflows/local/prepare_genome/main.nf
Line 21 in 5793f37
Add tests for subworkflow
PREPARE_GENOME.Updated shapshots for existing pipeline tests.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).