Skip to content

3262 Fix pipeline lint bug for pipelines with minimal template features #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

awgymer
Copy link
Contributor

@awgymer awgymer commented Oct 30, 2024

files_unchanged test creates a copy of the pipeline to lint against. But for pipelines with template sections excluded this template config was not used to create the copy pipeline.

This created an issue when the copy pipeline is created because it attempts to run prettier but files to be excluded are not properly excluded.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@mirpedrol
Copy link
Member

🧹 spring cleaning message 🌷

I think this is fixed now with version 3.2.0. Can I close this PR?

Copy link
Contributor

This PR has been tagged as awaiting-changes or awaiting-feedback by an nf-core contributor. Remove stale label or add a comment if it is still useful.

@github-actions github-actions bot added the Stale label Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants