-
Notifications
You must be signed in to change notification settings - Fork 201
Moved all singularity-related download functions into a new file #3509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
muffato
wants to merge
31
commits into
dev
Choose a base branch
from
singularity_downloads
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,321
−749
Draft
Changes from 12 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
ae0d4dd
Moved all singularity-related download functions into a new file
muffato bbd297f
Added a helper method to use a temporary file as intermediate output
muffato a9b2b00
First round of fixing the tests
muffato dc333b3
downloads.singularity functions should rely on proper parameters, no …
muffato fbc09ac
Duplicated with the line above
muffato fee7182
Added tests for utils.intermediate_file and fixed it !
muffato c507d9e
Simpler implementation
muffato aba5233
Added helper functions to manage the main task so that callers don't …
muffato 0403a37
No need to build a temp path here
muffato 159c34e
More tests
muffato 693da64
Fixed the symlink_registries tests
muffato c5379fb
Rewrote to support older versions of Python
muffato 8ee8eed
Added a dest for the main_task-management methods added to DownloadPr…
muffato 71ab538
Added some tests for the DownloadProgress object
muffato a141820
Turned two methods into functions, simplified testing
muffato 4133c90
Test comments
muffato 2b8fbd6
Theoretically it could be None, so check it really is a string
muffato 7813f30
More type hints
muffato cb71d42
More tests for get_container_filename
muffato 2d8cb4d
No need to keep a wraper as a method
muffato 4bfb45e
Better comments
muffato d6b8f6c
New class to support the downloads
muffato 4abd736
Introduced a context manager that creates a new sub task. Useful to g…
muffato 31f5627
Forgot that pytest.raises exists !
muffato 06d3760
Moved the download class to utils
muffato 3857fae
The output path cannot be a directory or a symbolic link
muffato 31fe914
Basic test for FileDownloader.download_file
muffato 02cc2ca
Empty files are not allowed
muffato b648bc1
Test log.debug too
muffato 467ba3f
Test the kill_with_fire flag
muffato ea4bc89
Refactored the FileDownloader
muffato File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,6 @@ env/ | |
| build/ | ||
| develop-eggs/ | ||
| dist/ | ||
| downloads/ | ||
| eggs/ | ||
| .eggs/ | ||
| lib64/ | ||
|
|
||
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned in #3506 (comment), the directory name should be
downloadThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my decision to avoid import errors for now. Running
git mvis later is pretty quick, I guess.