Add more ruff rules (B, PTH, RSE, SIM, C4, BLE, A)#4034
Open
mashehu wants to merge 58 commits intonf-core:devfrom
Open
Add more ruff rules (B, PTH, RSE, SIM, C4, BLE, A)#4034mashehu wants to merge 58 commits intonf-core:devfrom
mashehu wants to merge 58 commits intonf-core:devfrom
Conversation
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mashehu
changed the title
mashehu
force-pushed
the
new-ruff-rules
branch
from
8dac8db to
b53e971
Compare
mashehu
changed the title
mashehu
changed the title
mashehu
force-pushed
the
new-ruff-rules
branch
from
a84464a to
084389c
Compare
mashehu
changed the title
Contributor
Author
|
hah, looks like most of these new rules are anyway part of an upcoming set of default ruff rules: astral-sh/ruff#23203 |
mashehu
force-pushed
the
new-ruff-rules
branch
3 times, most recently
from
b2cd1b3 to
dada220
Compare
mashehu
changed the title
fabianegli
reviewed
Mar 9, 2026
nf_core/synced_repo.py
Outdated
| """ | ||
| dir_names = os.listdir(self.local_repo_dir) | ||
| if "modules" not in dir_names: | ||
| assert self.local_repo_dir is not None, "Repository must be initialized before verifying branch" |
Contributor
There was a problem hiding this comment.
assert outside test code should be avoided. See #1533 for reference.
fabianegli
reviewed
Mar 9, 2026
nf_core/modules/modules_utils.py
Outdated
|
|
||
| # Remove the file extension from the path | ||
| path, _ = os.path.splitext(path) | ||
| path = str(Path(path).with_suffix("")) |
Contributor
There was a problem hiding this comment.
This could be .stem.
Sidenote: The variable path is reassigned. A new variable with the name full_name or something similar would be more descriptive and fit the function better.
Contributor
Author
There was a problem hiding this comment.
Looking into it, and I don't think that .stem would be the same here. we want to have nf-core/modules as a full_name for example, where .stem would give us just modules
Path().open is just a wrapper around open() and so doesn't add anything
# Conflicts: # CHANGELOG.md # Conflicts: # CHANGELOG.md # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional rules we could add: