Added new classes & slots in coremeta4cat_reaction_ap.yaml - #118
Merged
Conversation
Closed
HendrikBorgelt
added a commit
to HendrikBorgelt/CoreMeta4Cat
that referenced
this pull request
Jul 14, 2026
…rtifacts Rebasing onto upstream/main surfaced additional duplication beyond the already-resolved coremeta4cat_reaction_ap.yaml conflict: PR nfdi4cat#118 also added has_cathode/has_anode/has_cell_operating_mode/has_active_area/ has_faradaic_current and several catalyst-bed/stirrer geometry slots to coremeta4cat_common.yaml that duplicate slots already defined locally in coremeta4cat_reaction_ap.yaml (same concepts, same VOC4CAT terms in most cases, different slot names), plus has_conversion/has_space_time_yield/ has_selectivity referencing nfdi4cat#118's Conversion/SpaceTimeYield/Selectivity classes -- which aren't included in this PR (see the PR description's note on keeping those for separate discussion). Removes the now-orphaned duplicates so the schema resolves cleanly, and regenerates all derived artifacts against the final merged state.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added CatalystTypes, PerformanceMeasures, ReactionTypes and Reactor-Metadata field.