New terms from usecase beta - #255
Conversation
|
@dalito, I currently don't know why this error is caused. Maybe you can have a look |
resubmission of terms from usecase beta after PR nfdi4cat#249 failed due to bad rebasing Co-Authored-By: Ivo Kühnrich <258046891+ivokuehnrich@users.noreply.github.com> Co-Authored-By: arjunneyyathalaCat <240035935+arjunneyyathalaCat@users.noreply.github.com>
Corrected a mistake in the excel Co-Authored-By: Ivo Kühnrich <258046891+ivokuehnrich@users.noreply.github.com> Co-Authored-By: arjunneyyathalaCat <240035935+arjunneyyathalaCat@users.noreply.github.com>
Sorry for all the Mails caused here, it seems like i had made two mistakes, which i hopefully fix now. Co-Authored-By: Ivo Kühnrich <258046891+ivokuehnrich@users.noreply.github.com> Co-Authored-By: arjunneyyathalaCat <240035935+arjunneyyathalaCat@users.noreply.github.com>
c0ab47e to
b408e3c
Compare
|
The reason for the errors is probably trivial. Most new concepts have 8 characters in the IDs not 7 (but some have 7 in ParentIRI column). We should try to catch such deviation from 7-character IDs earlier (before passing the data to the SHACL validation) and provide a more meaningful error message. |
|
Starting with the next PR, an improved version of voc4cat-tool (v1.0.3) will be used. It detects IDs with more than 7 digits early and errors/stops with a meaningful message. Here you can just push an updated xslx file with corrected IDs. |
Corrected the ID range mistake
dalito
left a comment
dalito
left a comment
There was a problem hiding this comment.
Please address the minor points in the comments.
The voc-assistant did not detect any duplicates.
implemented the changes requested by @dalito
…kBorgelt/voc4cat into new_terms_for_beta_update
dalito
left a comment
dalito
left a comment
There was a problem hiding this comment.
This looks good now. Thanks!
I need to revisit how dcterms:modified is updated too make PRs less noisy. I tested mainly with PRs created and merged on the same day...
github-project-automation
Bot
moved this from In progress
to Completed
in Voc4Cat cross-repo view
2 participants
resubmission of terms from usecase beta after PR #249 failed due to bad rebasing
Thank you for opening a Pull Request! After creating, check the boxes below to confirm: