Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1532 +/- ##
=======================================
Coverage 85.02% 85.02%
=======================================
Files 103 103
Lines 13587 13589 +2
=======================================
+ Hits 11552 11554 +2
Misses 1518 1518
Partials 517 517
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
aphralG
reviewed
Feb 20, 2026
...ector/containermetricsreceiver/internal/scraper/memoryscraper/internal/cgroup/memory_test.go
Show resolved
Hide resolved
|
|
||
| // Assert error | ||
| assert.IsType(tt, test.errorType, err) | ||
| if test.errorType == nil { |
Contributor
There was a problem hiding this comment.
Instead would something like this work ?
Suggested change
| if test.errorType == nil { | |
| if test.errorType != nil { | |
| require.ErrorIs(tt, test.errorType, err) | |
| } else { | |
| require.NoError(tt, err) | |
| } |
Contributor
There was a problem hiding this comment.
Will this change not work with the linter ?
Contributor
Author
There was a problem hiding this comment.
I did fix the code based on the review comment.
Contributor
Author
|
Opened a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)