[V3] updated go and lint version #1532
+117
−87
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| OAPICODEGEN = github.com/deepmap/oapi-codegen/v2/cmd/[email protected] | ||
| LEFTHOOK = github.com/evilmartians/[email protected] | ||
| GOLANGCILINT = github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.10.0 | ||
| PROTOCGENGO = google.golang.org/protobuf/cmd/[email protected] | ||
| GOFUMPT = mvdan.cc/[email protected] | ||
| COUNTERFEITER = github.com/maxbrunsfeld/counterfeiter/v6@v6.11.2 | ||
| NFPM = github.com/goreleaser/nfpm/v2/cmd/[email protected] | ||
| GOTESTCOVERAGE = github.com/vladopajic/go-test-coverage/[email protected] | ||
| BENCHSTAT = golang.org/x/perf/cmd/[email protected] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,8 +13,9 @@ import ( | |
| "strconv" | ||
| "testing" | ||
|
|
||
| "github.com/pkg/errors" | ||
| "github.com/shirou/gopsutil/v4/mem" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestVirtualMemoryStat(t *testing.T) { | ||
|
|
@@ -115,10 +116,18 @@ func TestVirtualMemoryStat(t *testing.T) { | |
| virtualMemoryStat, err := cgroupCPUSource.VirtualMemoryStat() | ||
|
|
||
| // Assert error | ||
| if test.errorType == nil { | ||
| require.NoError(tt, err) | ||
| } else { | ||
| require.Error(tt, err) | ||
| // satisfy the linter's requirement for a more specific check than IsType. | ||
| require.Condition(tt, func() bool { | ||
| return errors.As(err, &test.errorType) | ||
Akshay2191 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, "Error should be of type %T", test.errorType) | ||
| } | ||
|
|
||
| // Assert result | ||
| require.Equal(tt, test.virtualMemoryStat, *virtualMemoryStat) | ||
| }) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -74,7 +74,7 @@ func NewScraper( | |
| mb := metadata.NewMetricsBuilder(cfg.MetricsBuilderConfig, settings) | ||
| rb := mb.NewResourceBuilder() | ||
|
|
||
| operators := make([]operator.Config, 0, len(cfg.AccessLogs)) | ||
|
|
||
| for _, accessLog := range cfg.AccessLogs { | ||
| logger.Info("Adding access log file operator", zap.String("file_path", accessLog.FilePath)) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,5 +5,5 @@ | |
|
|
||
| package types | ||
|
|
||
| //go:generate go run github.com/maxbrunsfeld/counterfeiter/v6@v6.11.2 -generate | ||
| //counterfeiter:generate . CollectorInterface | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,7 @@ import ( | |
|
|
||
| var _ bus.Plugin = (*CommandPlugin)(nil) | ||
|
|
||
| //go:generate go run github.com/maxbrunsfeld/counterfeiter/v6@v6.11.2 -generate | ||
| //counterfeiter:generate . commandService | ||
|
|
||
| type ( | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.