Add nodePort for LoadBalancer only if allocateLoadBalancerNodePorts#10082
Open
Chupaka wants to merge 3 commits into
Open
Add nodePort for LoadBalancer only if allocateLoadBalancerNodePorts#10082Chupaka wants to merge 3 commits into
Chupaka wants to merge 3 commits into
Conversation
Contributor
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Author
|
I have hereby read the F5 CLA and agree to its terms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
In v3.7.0 the chart started to set nodePort field for LoadBalancer service type in addition to NodePort type. But if we disable allocateLoadBalancerNodePorts, we don't need to set nodePorts.
Also, allocateLoadBalancerNodePorts is true by default (in k8s), not false.
Checklist
Before creating a PR, run through this checklist and mark each as complete.