Skip to content

Add nodePort for LoadBalancer only if allocateLoadBalancerNodePorts#10082

Open
Chupaka wants to merge 3 commits into
nginx:mainfrom
Chupaka:lb_nodeports
Open

Add nodePort for LoadBalancer only if allocateLoadBalancerNodePorts#10082
Chupaka wants to merge 3 commits into
nginx:mainfrom
Chupaka:lb_nodeports

Conversation

@Chupaka
Copy link
Copy Markdown

@Chupaka Chupaka commented Jun 2, 2026

Proposed changes

In v3.7.0 the chart started to set nodePort field for LoadBalancer service type in addition to NodePort type. But if we disable allocateLoadBalancerNodePorts, we don't need to set nodePorts.

Also, allocateLoadBalancerNodePorts is true by default (in k8s), not false.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@Chupaka
Copy link
Copy Markdown
Author

Chupaka commented Jun 2, 2026

I have hereby read the F5 CLA and agree to its terms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo ☑

Development

Successfully merging this pull request may close these issues.

1 participant