Skip to content

Add nodePort for LoadBalancer only if allocateLoadBalancerNodePorts #10082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chupaka wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add nodePort for LoadBalancer only if allocateLoadBalancerNodePorts #10082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3f827b
Add nodePort for LoadBalancer only if allocateLoadBalancerNodePorts
Chupaka Jun 2, 2026
f3efba6
Use default value for allocateLoadBalancerNodePorts in values.yaml
Chupaka Jun 2, 2026
d4a6ab8
Merge branch 'main' into lb_nodeports
Chupaka Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/nginx-ingress/templates/controller-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ spec:
targetPort: {{ .Values.controller.service.httpPort.targetPort }}
protocol: TCP
name: {{ .Values.controller.service.httpPort.name }}
{{- if or (eq .Values.controller.service.type "LoadBalancer") (eq .Values.controller.service.type "NodePort") }}
{{- if or (eq .Values.controller.service.type "NodePort") (and (eq .Values.controller.service.type "LoadBalancer") (ternary .Values.controller.service.allocateLoadBalancerNodePorts true (hasKey .Values.controller.service "allocateLoadBalancerNodePorts"))) }}
nodePort: {{ .Values.controller.service.httpPort.nodePort }}
{{- end }}
{{- end }}
Expand All @@ -63,7 +63,7 @@ spec:
targetPort: {{ .Values.controller.service.httpsPort.targetPort }}
protocol: TCP
name: {{ .Values.controller.service.httpsPort.name }}
{{- if or (eq .Values.controller.service.type "LoadBalancer") (eq .Values.controller.service.type "NodePort") }}
{{- if or (eq .Values.controller.service.type "NodePort") (and (eq .Values.controller.service.type "LoadBalancer") (ternary .Values.controller.service.allocateLoadBalancerNodePorts true (hasKey .Values.controller.service "allocateLoadBalancerNodePorts"))) }}
nodePort: {{ .Values.controller.service.httpsPort.nodePort }}
{{- end }}
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion charts/nginx-ingress/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1443,7 +1443,7 @@
]
},
"allocateLoadBalancerNodePorts": {
"default": false,
"default": true,
"title": "The allocateLoadBalancerNodePorts Schema",
"$ref": "https://raw.githubusercontent.com/nginxinc/kubernetes-json-schema/master/v1.35.1/_definitions.json#/definitions/io.k8s.api.core.v1.ServiceSpec/properties/allocateLoadBalancerNodePorts"
},
Expand Down
2 changes: 1 addition & 1 deletion charts/nginx-ingress/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ controller:
loadBalancerSourceRanges: []

## Whether to automatically allocate NodePorts (only for LoadBalancers).
# allocateLoadBalancerNodePorts: false
# allocateLoadBalancerNodePorts: true

## Dual stack preference.
## Valid values: SingleStack, PreferDualStack, RequireDualStack
Expand Down
Loading