Update traffic policy example to work #207
Conversation
The main issue was that we had a mix of spaces and tabs, and that makes yaml parsers unhappy. Before: ``` 2025/06/18 08:40:32 INFO client session established 2025/06/18 08:40:32 The TrafficPolicy you provided is invalid: could not decode from string: The traffic policy was not able to be parsed: yaml: line 4: found a tab character that violates indentation. ``` After: ``` 2025/06/18 08:43:52 INFO client session established 2025/06/18 08:43:52 Endpoint online https://<random>.ngrok.app ``` I also plumbed in slog since otherwise there's no output on errors, which is kinda unsettling.
|
hmmm, the test failures are for an unrelated CI reason that i'll need to track down. not sure what's going on there when you say there was no output on errors, that's surprising, wouldn't that have occurred from the log.Fatal()? or is this because we're retrying behind the scenes and not returning an error? |
|
The lack of output is because we're infinitely retrying errors, including invalid auth tokens and invalid traffic policy document errors. That's tracked over here: #176 |
I accidentally made the PR from my fork of the repo rather than from a branch on the repo, so it can't use the repo's secrets. That's my bad. I'll open a fresh PR, since otherwise CI blocks merging |
|
Re-created over in #208. Since we require CI for the merge button, it seems most pragmatic to split to a new PR, apologies for the extra noise! |
3 participants
The main issue was that we had a mix of spaces and tabs, and that makes yaml parsers unhappy.
Before:
After:
I also plumbed in slog since otherwise there's no output on errors, which is kinda unsettling.