Update traffic policy example to work #208
Merged
+28
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main issue was that we had a mix of spaces and tabs, and that makes yaml parsers unhappy. Before: ``` 2025/06/18 08:40:32 INFO client session established 2025/06/18 08:40:32 The TrafficPolicy you provided is invalid: could not decode from string: The traffic policy was not able to be parsed: yaml: line 4: found a tab character that violates indentation. ``` After: ``` 2025/06/18 08:43:52 INFO client session established 2025/06/18 08:43:52 Endpoint online https://<random>.ngrok.app ``` I also plumbed in slog since otherwise there's no output on errors, which is kinda unsettling.
inconshreveable
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-creation of #207, since that one was a PR from a fork, and our current CI setup only works for first-party PRs, not PRs-from-forks... which of course I think we should fix, but it seems like it's out of scope of this change.
The main issue was that we had a mix of spaces and tabs, and that makes yaml parsers unhappy.
Before:
After:
I also plumbed in slog since otherwise there's no output on errors, which is kinda unsettling.