Skip to content

Conversation

@jonstacks
Copy link
Collaborator

What

We have several places where we manage dependencies. We have some currently consumed via nix, some via github actions, some via Makefile, and naturally our go dependencies. Having to update our Makefile dependencies periodically as opposed to just running nix flake update like we already do for go version increases complexity. We're looking at moving many of these to nix and out of go tools where appropriate.

How

  • Pull golangci-lint from nixpkgs instead of via makefile
  • Updates CI to install nix so that golangci-lint is on the path for make lint
  • As part of using the nix provided golangci-lint, we're using version 2 of golangci-lint now, so this updates the .golangci-lint version to match

Breaking Changes

No, this is an internal build system only change

This also updates the version of golangci-lint we are using to v2 and removes it from the bootstrapable tools
@jonstacks jonstacks self-assigned this Dec 9, 2025
@jonstacks jonstacks requested a review from a team as a code owner December 9, 2025 21:42
@github-actions github-actions bot added area/ci Issues/PRs relating to CI size/L Denotes a PR that changes 100-499 lines labels Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.86%. Comparing base (4d223a0) to head (0dc6cbf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
- Coverage   48.94%   48.86%   -0.08%     
==========================================
  Files          95       95              
  Lines       10594    10594              
==========================================
- Hits         5185     5177       -8     
- Misses       5046     5053       +7     
- Partials      363      364       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@alex-bezek alex-bezek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update this contributing guide for the non-nix users to have a list of things you need to install manually https://github.com/ngrok/ngrok-operator/tree/main/docs/developer-guide#non-codespaces

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 10, 2025
@jonstacks
Copy link
Collaborator Author

Should we also update this contributing guide for the non-nix users to have a list of things you need to install manually https://github.com/ngrok/ngrok-operator/tree/main/docs/developer-guide#non-codespaces

Good call out. Updated the developer documentation

@jonstacks jonstacks enabled auto-merge December 10, 2025 20:19
@jonstacks jonstacks added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit c9eb45f Dec 10, 2025
11 checks passed
@jonstacks jonstacks deleted the stacks/golang-ci-lint-from-nixpkgs branch December 10, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci Issues/PRs relating to CI documentation Improvements or additions to documentation size/L Denotes a PR that changes 100-499 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants