Remove the deprecated cloud endpoint domain status #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
=======================================
Coverage 48.98% 48.98%
=======================================
Files 95 95
Lines 10594 10570 -24
=======================================
- Hits 5189 5178 -11
+ Misses 5046 5026 -20
- Partials 359 366 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonstacks
approved these changes
Dec 11, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In this PR https://github.com/ngrok/ngrok-operator/pull/679/files#diff-b2206470838051c0d76b729350195b5a133344c1026e88609727a305cc279bb4R97 we added a new DomainRef field in the status to make this CRD consistent with the AgentEndpoint CRD and maintained both status fields for passivity. This removes the old field.
How
Delete the code for the old field.
Breaking Changes
Yes but minor, it removes the
.status.domainfield in favor of the new.status.domainReffield.