Skip to content

Conversation

@alex-bezek
Copy link
Collaborator

…ds for consistency

What

Fixes the k8s documentation for these fields to be consistent with our other condition fields on other CRDs

How

Copy the same style of documentation we have in the other CRDs

// Conditions describe the current conditions of the AgentEndpoint.
//
// +kubebuilder:validation:Optional
// +listType=map
// +listMapKey=type
// +kubebuilder:validation:MaxItems=8
Conditions []metav1.Condition `json:"conditions,omitempty"`

Breaking Changes

Are there any breaking changes in this PR?

@alex-bezek alex-bezek requested a review from a team as a code owner December 11, 2025 05:44
@github-actions github-actions bot added area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart size/XS Denotes a PR that changes 0-9 lines labels Dec 11, 2025
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.93%. Comparing base (e03c2d6) to head (e613402).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
- Coverage   48.98%   48.93%   -0.05%     
==========================================
  Files          95       95              
  Lines       10594    10594              
==========================================
- Hits         5189     5184       -5     
- Misses       5046     5048       +2     
- Partials      359      362       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alex-bezek alex-bezek added this pull request to the merge queue Dec 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2025
@jonstacks jonstacks added this pull request to the merge queue Dec 11, 2025
Merged via the queue into main with commit ad3380d Dec 11, 2025
11 checks passed
@jonstacks jonstacks deleted the alex/status-conditions-types branch December 11, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart size/XS Denotes a PR that changes 0-9 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants