Update visually hidden behaviour to match GOV.UK Frontend#1170
Merged
Conversation
colinrotherham
force-pushed
the
visually-hidden
branch
from
fce517e to
5113407
Compare
colinrotherham
force-pushed
the
table-classes
branch
from
c966542 to
527bac3
Compare
colinrotherham
force-pushed
the
visually-hidden
branch
3 times, most recently
from
d58e071 to
5ddc8c8
Compare
colinrotherham
force-pushed
the
table-classes
branch
from
23551c6 to
8d75b38
Compare
colinrotherham
force-pushed
the
visually-hidden
branch
from
5ddc8c8 to
c5bed87
Compare
colinrotherham
force-pushed
the
visually-hidden
branch
2 times, most recently
from
04d830e to
f6961d0
Compare
Contributor
|
Looks good. Is this basically re-applying the same changes as in alphagov/govuk-frontend#5063 ? |
colinrotherham
force-pushed
the
visually-hidden
branch
from
f6961d0 to
531acd9
Compare
colinrotherham
force-pushed
the
visually-hidden
branch
from
531acd9 to
c40251e
Compare
colinrotherham
force-pushed
the
visually-hidden
branch
from
c40251e to
0b4bd92
Compare
3 tasks
edwardhorsford
approved these changes
Apr 7, 2025
Contributor
edwardhorsford
left a comment
edwardhorsford
left a comment
There was a problem hiding this comment.
Ran the branch locally, can't see any issues. The column headers on the table seem to wrap as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1169 by applying alphagov/govuk-frontend#5063
Checklist