Focus skip link target to improve screen reader announcements#1173
Merged
Conversation
colinrotherham
force-pushed
the
visually-hidden-focusable
branch
from
a0fe469 to
1164f8c
Compare
colinrotherham
changed the title
This was referenced Mar 5, 2025
Closed
This was
linked to
issues
Mar 5, 2025
Closed
colinrotherham
force-pushed
the
visually-hidden
branch
from
d58e071 to
5ddc8c8
Compare
colinrotherham
force-pushed
the
visually-hidden-focusable
branch
from
1164f8c to
2f5a144
Compare
colinrotherham
force-pushed
the
visually-hidden
branch
from
5ddc8c8 to
c5bed87
Compare
colinrotherham
force-pushed
the
visually-hidden-focusable
branch
from
2f5a144 to
8366ac4
Compare
colinrotherham
force-pushed
the
visually-hidden
branch
from
c5bed87 to
04d830e
Compare
colinrotherham
force-pushed
the
visually-hidden-focusable
branch
from
8366ac4 to
f6a6c4f
Compare
colinrotherham
force-pushed
the
visually-hidden
branch
from
04d830e to
f6961d0
Compare
colinrotherham
force-pushed
the
visually-hidden-focusable
branch
from
f6a6c4f to
297ae1d
Compare
colinrotherham
force-pushed
the
visually-hidden
branch
from
f6961d0 to
531acd9
Compare
colinrotherham
force-pushed
the
visually-hidden-focusable
branch
from
297ae1d to
792c0f0
Compare
colinrotherham
force-pushed
the
visually-hidden
branch
from
531acd9 to
c40251e
Compare
colinrotherham
force-pushed
the
visually-hidden-focusable
branch
from
792c0f0 to
a5169ab
Compare
colinrotherham
force-pushed
the
visually-hidden
branch
from
c40251e to
0b4bd92
Compare
colinrotherham
force-pushed
the
visually-hidden-focusable
branch
2 times, most recently
from
4140af7 to
0c5ee10
Compare
anandamaryon1
previously approved these changes
Apr 7, 2025
edwardhorsford
previously approved these changes
Apr 7, 2025
Contributor
edwardhorsford
left a comment
edwardhorsford
left a comment
There was a problem hiding this comment.
Lovely stuff. Glad to see focussing the h1 fixed.
I was going to suggest updating the layout guidance in the service manual, but it looks like that implied the main ID got used anyway.
Contributor
Author
|
Thanks @edwardhorsford @anandamaryon1 If you can take a look at #1170 too? That's the one that swaps the visually hidden code over to what GOV.UK Frontend uses |
colinrotherham
dismissed stale reviews from edwardhorsford and anandamaryon1
The base branch was changed.
colinrotherham
force-pushed
the
visually-hidden-focusable
branch
from
0c5ee10 to
7c631ad
Compare
edwardhorsford
approved these changes
Apr 7, 2025
colinrotherham
added a commit
that referenced
this pull request
Apr 8, 2025
Restores skip link `z-index: 2` from #1173
3 tasks
colinrotherham
added a commit
that referenced
this pull request
Apr 10, 2025
Restores skip link `z-index: 2` from #1173
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Skip link to call
.focus()on itshref="#maincontent"target to follow:These changes build on top of #1169 and fix:
Visually hidden (focusable)
I've also included:
visually-hidden-focusablenhsuk-u-visually-hidden-focusableThese were applied to the skip link component
Checklist