Bugfix: don't have text aligned left in buttons in button group#1451
Merged
Conversation
This only effects buttons where you've set a minimum width (eg because the text is quite short).
anandamaryon1
approved these changes
Jun 30, 2025
Contributor
anandamaryon1
left a comment
anandamaryon1
left a comment
There was a problem hiding this comment.
Good spot, thanks.
Looks good to me but still having issues with backstop :/
Contributor
|
@anandamaryon1 @frankieroberto Looks like we get a new backstop issue each week This time it's multiple concurrent test I've fixed it in #1447 |
Contributor
colinrotherham
left a comment
colinrotherham
left a comment
There was a problem hiding this comment.
But don't we want to keep text-align: left for paragraph text?
With this PR, if you add a min-width to a paragraph it's now centre-aligned
Contributor
|
Could you take a look now? |
|
colinrotherham
approved these changes
Jul 1, 2025
Contributor
colinrotherham
left a comment
colinrotherham
left a comment
There was a problem hiding this comment.
@frankieroberto @anandamaryon1 Happy if we merge this?
anandamaryon1
approved these changes
Jul 2, 2025
colinrotherham
added a commit
that referenced
this pull request
Jul 22, 2025
…-group Bugfix: don't have text aligned left in buttons in button group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only effects buttons where you've set a minimum width (eg because the text is quite short).
Fixes an accidental change in #1309.
Checklist