Skip to content

Bugfix: don't have text aligned left in buttons in button group #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colinrotherham merged 3 commits into from
Jul 2, 2025
Merged

Bugfix: don't have text aligned left in buttons in button group #1451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
306a9a5
Bugfix: don't have text aligned left in buttons in button group
frankieroberto Jun 30, 2025
dabad45
Match selectors and media queries between mobile/tablet
colinrotherham Jun 30, 2025
5f16278
Restore `text-align: left` to non-buttons
colinrotherham Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/nhsuk-frontend-review/src/examples/button-group.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@
<a href="#" class="nhsuk-link">Buy it</a>

{{ button({
"text": "Use it"
"text": "Use it",
attributes: {
style: "min-width: 150px;"
}
}) }}

{{ button({
Expand Down
18 changes: 9 additions & 9 deletions packages/nhsuk-frontend/src/nhsuk/core/objects/_button-group.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,20 +50,15 @@
// Prevent links overflowing their container in IE10/11 because of bug
// with align-items: center
max-width: 100%;
margin-top: $button-padding-top-bottom-desktop + $nhsuk-border-width-form-element;
margin-bottom: $button-padding-top-bottom-desktop + $nhsuk-border-width-form-element;
margin-top: $link-spacing;
margin-bottom: $link-spacing + $vertical-gap;
text-align: center;
@include nhsuk-font($size: 19);

@include nhsuk-media-query($until: tablet) {
margin-top: $link-spacing;
margin-bottom: $link-spacing + $vertical-gap;
}
}

// Reduce the bottom margin to the size of the vertical gap (accommodating
// the button shadow) – the 'lost' margin is moved to the button-group.
.nhsuk-button {
> .nhsuk-button {
margin-bottom: $vertical-gap + $button-shadow-size;
}

Expand All @@ -80,12 +75,17 @@
.nhsuk-body,
.nhsuk-body-m,
p,
> .nhsuk-button,
> .nhsuk-link,
> a:not(.nhsuk-button) {
margin-top: $button-padding-top-bottom-desktop + $nhsuk-border-width-form-element;
margin-bottom: $button-padding-top-bottom-desktop + $nhsuk-border-width-form-element;
margin-right: $horizontal-gap;
text-align: left;
}

> .nhsuk-button {
margin-right: $horizontal-gap;
}
}
}
}