Skip to content

Remove installation of visualstudio2022-workload-vctools during build#446

Merged
jasonmreding merged 4 commits intoni:masterfrom
jplotzke:jplotzke/build_failure
May 16, 2025
Merged

Remove installation of visualstudio2022-workload-vctools during build#446
jasonmreding merged 4 commits intoni:masterfrom
jplotzke:jplotzke/build_failure

Conversation

@jplotzke
Copy link
Copy Markdown
Contributor

@jplotzke jplotzke commented May 16, 2025

Starting recently, the choco package visualstudio2022-workload-vctools requests a reboot during install on a Github runner while running the x86/x64 build actions.

Because the Github windows-2022 runner already includes Visual Studio 2022, installation of visualstudio2022-workload-vctools is not required. Both the x86 and x64 builds are successful without this installation step.

Previously, the build output shows (and fails with error 3010)

visualstudio2022-workload-vctools v1.0.0 [Approved] - Possibly broken
visualstudio2022-workload-vctools package files install completed. Performing other installation steps.
Installing visualstudio2022-workload-vctools...

WARNING: visualstudio2022-workload-vctools has been installed. However, a reboot is required to finalize the installation.
WARNING: visualstudio2022-workload-vctools has been installed. However, a reboot is required to finalize the installation.
  visualstudio2022-workload-vctools may be able to be automatically uninstalled.
 The install of visualstudio2022-workload-vctools was successful.
  Software install location not explicitly set, it could be in package or
  default install location of installer.

Chocolatey installed 6/6 packages. 
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Installed:
 - chocolatey-dotnetfx.extension v1.0.1
 - chocolatey-visualstudio.extension v1.11.1
 - dotnetfx v4.8.0.20220524
 - visualstudio2022buildtools v117.14.0
 - visualstudio2022-workload-vctools v1.0.0
 - visualstudio-installer v2.0.3

Packages requiring reboot:
 - visualstudio2022-workload-vctools (exit code 3010)

The recent package changes indicate a reboot is necessary.
 Please reboot at your earliest convenience.

@jasonmreding jasonmreding requested a review from Copilot May 16, 2025 14:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the installation steps in the Windows build workflows to trap and ignore error code 3010 from installing visualstudio2022-workload-vctools, allowing the build process to complete successfully without a system reboot interruption.

  • Revised the install logic in Windows x86 and x64 build workflows.
  • Added conditional checks in PowerShell to trap error 3010 and properly handle other error cases.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/windows_x86_build.yml Updated the installation step to trap error 3010 using PowerShell flow.
.github/workflows/windows_x64_build.yml Updated the installation step to trap error 3010 using PowerShell flow.

@jplotzke jplotzke changed the title Ignore reboot request from visualstudio2022-workload-vctools during build Remove installation of visualstudio2022-workload-vctools during build May 16, 2025
@jasonmreding jasonmreding merged commit 38e2c0d into ni:master May 16, 2025
5 checks passed
@jplotzke jplotzke deleted the jplotzke/build_failure branch June 8, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants