Remove installation of visualstudio2022-workload-vctools during build#446
Merged
jasonmreding merged 4 commits intoni:masterfrom May 16, 2025
Merged
Remove installation of visualstudio2022-workload-vctools during build#446jasonmreding merged 4 commits intoni:masterfrom
jasonmreding merged 4 commits intoni:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the installation steps in the Windows build workflows to trap and ignore error code 3010 from installing visualstudio2022-workload-vctools, allowing the build process to complete successfully without a system reboot interruption.
- Revised the install logic in Windows x86 and x64 build workflows.
- Added conditional checks in PowerShell to trap error 3010 and properly handle other error cases.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/windows_x86_build.yml | Updated the installation step to trap error 3010 using PowerShell flow. |
| .github/workflows/windows_x64_build.yml | Updated the installation step to trap error 3010 using PowerShell flow. |
bkeryan
reviewed
May 16, 2025
…already installed on github's windows-2022.
jasonmreding
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting recently, the choco package visualstudio2022-workload-vctools requests a reboot during install on a Github runner while running the x86/x64 build actions.
Because the Github
windows-2022runner already includes Visual Studio 2022, installation ofvisualstudio2022-workload-vctoolsis not required. Both the x86 and x64 builds are successful without this installation step.Previously, the build output shows (and fails with error 3010)