Skip to content

Remove installation of visualstudio2022-workload-vctools during build #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonmreding merged 4 commits into from
May 16, 2025
Merged

Remove installation of visualstudio2022-workload-vctools during build #446

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9dd45d
Add catch of error 3010 (reboot)
jplotzke May 16, 2025
c77e082
Update to return 0 if reboot was required
jplotzke May 16, 2025
19b9be6
Add catch of error 3010 (reboot) and ignore, instead return 0
jplotzke May 16, 2025
6e0c6fc
Remove installation of visualstudio2022-workload-vctools as they are …
jplotzke May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/windows_x64_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,18 @@ jobs:
- uses: ilammy/setup-nasm@v1.5.1

- name: Install Visual Studio 2022 Build Tools
shell: pwsh
run: |
choco install visualstudio2022-workload-vctools --yes || throw "Installation failed"
choco install visualstudio2022-workload-vctools --yes
if ($LASTEXITCODE -eq 3010) {
# Trap and ignore error 3010
Write-Host "Installation successful, reboot required. Ignoring and proceeding..."
exit 0
} elseif ($LASTEXITCODE -ne 0) {
# If another error happened (that wasn't 3010), then pass that error up
Write-Error "Installation failed with exit code $LASTEXITCODE"
exit $LASTEXITCODE
}

- name: Update Submodules
working-directory: ${{runner.workspace}}/grpc-labview
Expand Down
12 changes: 11 additions & 1 deletion .github/workflows/windows_x86_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,18 @@ jobs:
- uses: ilammy/setup-nasm@v1.5.1

- name: Install Visual Studio 2022 Build Tools
shell: pwsh
run: |
choco install visualstudio2022-workload-vctools --yes || throw "Installation failed"
choco install visualstudio2022-workload-vctools --yes
if ($LASTEXITCODE -eq 3010) {
# Trap and ignore error 3010
Write-Host "Installation successful, reboot required. Ignoring and proceeding..."
exit 0
} elseif ($LASTEXITCODE -ne 0) {
# If another error happened (that wasn't 3010), then pass that error up
Write-Error "Installation failed with exit code $LASTEXITCODE"
exit $LASTEXITCODE
}

- name: Update Submodules
working-directory: ${{runner.workspace}}/grpc-labview
Expand Down