Add array wrapper proto types for non-scalar batch measurements#161
Draft
Add array wrapper proto types for non-scalar batch measurements#161
Conversation
- Add vector_wrappers.proto (VectorArrayValue) - Add digital_waveform_wrappers.proto (DigitalWaveformArrayValue) - Add xydata_wrappers.proto (DoubleXYDataArrayValue) - Extend PublishMeasurementBatchRequest with 8 non-scalar value types (vector, double/i16 analog waveform, XY data, double/i16 complex waveform, double spectrum, digital waveform)
csjall
reviewed
Mar 26, 2026
Contributor
There was a problem hiding this comment.
Add to existing waveform_wrappers.proto.
nick-beer
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed?
Add three new array wrapper proto types and extend
PublishMeasurementBatchRequestto support non-scalar value types in batch measurement publishing.Implementation Details
New proto files:
vector_wrappers.proto—VectorArrayValue(repeated Vector)digital_waveform_wrappers.proto—DigitalWaveformArrayValue(repeated DigitalWaveform)xydata_wrappers.proto—DoubleXYDataArrayValue(repeated DoubleXYData)Extended
PublishMeasurementBatchRequest:The
oneof valuesblock now supports 9 types (previously only scalar):scalar_values(existing)vector_values,double_analog_waveform_values,x_y_data_values,i16_analog_waveform_values,double_complex_waveform_values,i16_complex_waveform_values,double_spectrum_values,digital_waveform_valuesThis enables the result processor to batch non-scalar measurements (vectors, waveforms, XY data, spectra, digital waveforms) into a single gRPC round-trip instead of one per measurement.
Testing Done
Proto compilation verified in downstream datastore-service build.