generated from ni/github-repo-template
-
Notifications
You must be signed in to change notification settings - Fork 4
Add array wrapper proto types for non-scalar batch measurements #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rfriedma
wants to merge
6
commits into
main
Choose a base branch
from
users/rfriedma/results-perf-batch-nonscalar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
89effae
Add array wrapper proto types for non-scalar batch measurements
2e00928
Merge branch 'main' into users/rfriedma/results-perf-batch-nonscalar
rfriedma 7dd0c88
Move DigitalWaveformArrayValue into the existing waveform_wrappers.proto
mjohanse-emr e9b9090
Rename xy_data to x_y_data for consistency.
mjohanse-emr 822064e
Address review feedback by updating a comment
mjohanse-emr cc331a9
Merge branch 'main' into users/rfriedma/results-perf-batch-nonscalar
mjohanse-emr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjohanse-emr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Wrappers for the DigitalWaveform message type. These types are useful | ||
| // for embedding in the google.protobuf.Any type or in oneof fields. | ||
| // Their use outside of these scenarios is discouraged. | ||
|
|
||
| //--------------------------------------------------------------------- | ||
| //--------------------------------------------------------------------- | ||
| syntax = "proto3"; | ||
|
|
||
| //--------------------------------------------------------------------- | ||
| //--------------------------------------------------------------------- | ||
| package ni.protobuf.types; | ||
|
|
||
| import "ni/protobuf/types/waveform.proto"; | ||
|
|
||
| //--------------------------------------------------------------------- | ||
| //--------------------------------------------------------------------- | ||
| option csharp_namespace = "NationalInstruments.Protobuf.Types"; | ||
| option go_package = "types"; | ||
| option java_multiple_files = true; | ||
| option java_outer_classname = "DigitalWaveformWrappersProto"; | ||
| option java_package = "com.ni.protobuf.types"; | ||
| option objc_class_prefix = "NIPT"; | ||
| option php_namespace = "NI\\PROTOBUF\\TYPES"; | ||
| option ruby_package = "NI::Protobuf::Types"; | ||
|
|
||
| // An array of digital waveforms. | ||
| message DigitalWaveformArrayValue { | ||
| repeated DigitalWaveform waveforms = 1; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Wrappers for the Vector message type. These types are useful | ||
| // for embedding in the google.protobuf.Any type or in oneof fields. | ||
| // Their use outside of these scenarios is discouraged. | ||
|
|
||
| //--------------------------------------------------------------------- | ||
| //--------------------------------------------------------------------- | ||
| syntax = "proto3"; | ||
|
|
||
| //--------------------------------------------------------------------- | ||
| //--------------------------------------------------------------------- | ||
| package ni.protobuf.types; | ||
|
|
||
| import "ni/protobuf/types/vector.proto"; | ||
|
|
||
| //--------------------------------------------------------------------- | ||
| //--------------------------------------------------------------------- | ||
| option csharp_namespace = "NationalInstruments.Protobuf.Types"; | ||
| option go_package = "types"; | ||
| option java_multiple_files = true; | ||
| option java_outer_classname = "VectorWrappersProto"; | ||
| option java_package = "com.ni.protobuf.types"; | ||
| option objc_class_prefix = "NIPT"; | ||
| option php_namespace = "NI\\PROTOBUF\\TYPES"; | ||
| option ruby_package = "NI::Protobuf::Types"; | ||
|
|
||
| // An array of vectors. | ||
| message VectorArrayValue { | ||
mjohanse-emr marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| repeated Vector vectors = 1; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Wrappers for the DoubleXYData message type. These types are useful | ||
| // for embedding in the google.protobuf.Any type or in oneof fields. | ||
| // Their use outside of these scenarios is discouraged. | ||
|
|
||
| //--------------------------------------------------------------------- | ||
| //--------------------------------------------------------------------- | ||
| syntax = "proto3"; | ||
|
|
||
| //--------------------------------------------------------------------- | ||
| //--------------------------------------------------------------------- | ||
| package ni.protobuf.types; | ||
|
|
||
| import "ni/protobuf/types/xydata.proto"; | ||
|
|
||
| //--------------------------------------------------------------------- | ||
| //--------------------------------------------------------------------- | ||
| option csharp_namespace = "NationalInstruments.Protobuf.Types"; | ||
| option go_package = "types"; | ||
| option java_multiple_files = true; | ||
| option java_outer_classname = "XYDataWrappersProto"; | ||
| option java_package = "com.ni.protobuf.types"; | ||
| option objc_class_prefix = "NIPT"; | ||
| option php_namespace = "NI\\PROTOBUF\\TYPES"; | ||
| option ruby_package = "NI::Protobuf::Types"; | ||
|
|
||
| // An array of XY data sets. | ||
| message DoubleXYDataArrayValue { | ||
| repeated DoubleXYData xy_data = 1; | ||
mjohanse-emr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.