_auditd_config.py: do not check permissions on file that doesn't exist#65
Merged
_auditd_config.py: do not check permissions on file that doesn't exist#65
Conversation
amstewart
requested changes
Apr 1, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This change avoids a FileNotFoundError exception when running 'verify' if auditd.conf doesn't exist. The exception causes 'verify' to print a stack trace and return error 1 rather than EX_CHECK_FAILURE. auditd.conf is not on the nilrt base system image; it's created by nilrt-snac. Thus, that exception would always happen when running 'verify' before running 'configure'. Signed-off-by: Alex Hearn <alex.hearn@ni.com>
AlexHearnNI
force-pushed
the
error_reporting
branch
from
228a0d7 to
247b119
Compare
AlexHearnNI
changed the title
amstewart
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
avoid FileNotFoundError exception when running
verifybeforeconfigureJustification
If
/etc/audit/auditd.confdoesn't exist, thenverifywill print a stack trace and return error 1 rather thanEX_CHECK_FAILURE.AB#3067833
Testing
I ran
nilrt-snac verify.Procedure