Skip to content

_auditd_config.py: do not check permissions on file that doesn't exist #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amstewart merged 1 commit into from
Apr 3, 2025
Merged

_auditd_config.py: do not check permissions on file that doesn't exist #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nilrt_snac/_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@


def _check_group_ownership(path: str, group: str) -> bool:
"Checks if the group ownership of a file or directory matches the specified group."
"Checks if the group ownership of a file or directory matches the specified group."
stat_info = os.stat(path)
gid = stat_info.st_gid
group_info = grp.getgrgid(gid)
Expand Down Expand Up @@ -38,4 +38,4 @@ def get_distro():
if line.startswith("ID="):
return line.split("=")[1].strip()
except NameError:
return None
return None
29 changes: 15 additions & 14 deletions nilrt_snac/_configs/_auditd_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,20 +182,21 @@ def verify(self, args: argparse.Namespace) -> bool:
if not auditd_config_file.exists():
valid = False
logger.error(f"MISSING: {auditd_config_file.path} not found")
elif not is_valid_email(auditd_config_file.get("action_mail_acct")):
valid = False
logger.error("MISSING: expected action_mail_acct value")

# Check group ownership and permissions of auditd.conf
if not _check_group_ownership(self.audit_config_path, "sudo"):
logger.error(f"ERROR: {self.audit_config_path} is not owned by the 'sudo' group.")
valid = False
if not _check_permissions(self.audit_config_path, 0o660):
logger.error(f"ERROR: {self.audit_config_path} does not have 660 permissions.")
valid = False
if not _check_owner(self.audit_config_path, "root"):
logger.error(f"ERROR: {self.audit_config_path} is not owned by 'root'.")
valid = False
else:
if not is_valid_email(auditd_config_file.get("action_mail_acct")):
valid = False
logger.error("MISSING: expected action_mail_acct value")

# Check group ownership and permissions of auditd.conf
if not _check_group_ownership(self.audit_config_path, "sudo"):
logger.error(f"ERROR: {self.audit_config_path} is not owned by the 'sudo' group.")
valid = False
if not _check_permissions(self.audit_config_path, 0o660):
logger.error(f"ERROR: {self.audit_config_path} does not have 660 permissions.")
valid = False
if not _check_owner(self.audit_config_path, "root"):
logger.error(f"ERROR: {self.audit_config_path} is not owned by 'root'.")
valid = False

# Check group ownership and permissions of /var/log
if not _check_group_ownership(self.log_path, "adm"):
Expand Down